Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the project still maintained? #133

Closed
jerep6 opened this issue Jun 18, 2017 · 15 comments
Closed

Is the project still maintained? #133

jerep6 opened this issue Jun 18, 2017 · 15 comments

Comments

@jerep6
Copy link

jerep6 commented Jun 18, 2017

Hi,

Given the number of pull requests and issues unanswered, I wonder if the project is still maintained.

Do you have more information?

@StevenACoffman
Copy link

StevenACoffman commented Jun 19, 2017

Answer is: sort of?

The original author @thenikso did a fabulous job, but was very up front about not being able to maintain it and asked for someone else to take over. There's been some great work by @HyperBrain and others, but it deserves a fairly sustained amount of effort to keep pace with both Webpack and Serverless. It's possible one or more maintainers will emerge, or it will be moved to the serverless organization and maintained there.

As for me and my co-workers, due to #116 and #120 ( #107 might be addressed in #130 ) we're considering removing the plugin, running webpack, and pointing serverless to the output.

NODE_ENV='production' node_modules/.bin/webpack --config webpack.config.js -p

@HyperBrain
Copy link
Member

In my experience this plugin offers the best integration of webpack and Serverless. It would be a loss if it would simply be shut down 😢 Especially building and testing React applications (including server-side rendering) are a pain without the plugin.

Nevertheless, to keep it usable the most important bugs have to be fixed (the ones that really block the use). I could have a look at some of the bugs and try to fix them, but as I'm already quite busy maintaining and contributing to other projects (my ones and Serverless) in my spare time, taking it over completely is currently not an option.

@StevenACoffman
Copy link

StevenACoffman commented Jun 20, 2017

Perhaps the pull request hack is called for:

Whenever somebody sends you a pull request, give them commit access to your project.

If yourself and others who have contributed pull requests were given access by @domaslasauskas or @thenikso (and also be able to add still more contributrors) it might get this project to a more sustainable place.

Maybe this ticket would be a good place:

  • for people to volunteer to help
  • to suggest people to help maintain this who may have contributed pull requests in the past

@franciscocpg
Copy link
Member

I agree with @StevenACoffman and I'm glad to help.

@johnf
Copy link

johnf commented Jun 25, 2017

I also use this heavily and would be happy to help.

@ricardolpd
Copy link

Our project at this moment is quite dependent on this plugin, and i personally would like to see this plugin moving forward as it is the best integration with with webpack and serverless i have seen. I would be happy to dedicate some of my time weekly for the forseable future making contributions for this project. How would you guys would like to go on about doing this?
Picking issues and trying to solve it, or just bring in suggested features as we need them and collectively review the pull-requests?

@StevenACoffman
Copy link

StevenACoffman commented Jun 27, 2017

Of the volunteers, @HyperBrain has a well established track record, and at the very least can add a few more maintainers here. @thenikso please add him as a collaborator to this npm module 1 and github repo 2.

While it is possible for a new github organization to emerge, and this code to be moved there, in the mean time these are the steps I suggest:

  • @thenikso adds the npm username maintainers as below 1
  • @thenikso adds @HyperBrain as a collaborator to the github repo as below 2
  • Potential maintainers provide both their npm userid and github user id here (e.g. hyperbrain for npm and HyperBrain for github)
  • @HyperBrain can add first few others as they step forward.

1 share npm maintainership like so:

cd serverless-webpack
npm adduser hyperbrain
npm owner add hyperbrain

2 share github maintainership like so:

  1. Navigate to the repository on Github you wish to share with your collaborator.
  2. Click on the "Settings" tab on the right side of the menu at the top of the screen.
  3. On the new page, click the "Collaborators" menu item on the left side of the page.
  4. Start typing the new collaborator's GitHub username (HyperBrain) into the text box.
  5. Select the GitHub user from the list that appears below the text box.
  6. Click the "Add" button.

@pmuens
Copy link

pmuens commented Jun 28, 2017

Hey guys, great to see efforts to build a community of maintainers around this heavily used plugin 🤘.

Just wanted to drop a line that there's also this GitHub org: https://github.com/serverless-community-labs

Maybe worthwhile to contact the developers of the Simulate plugin to join forces and build up one org where battle tested plugins are brewed 🍻 .

@thenikso
Copy link
Contributor

Wonderful news! I am very sorry for not having being able to sustain the work on this plugin. I'll execute what @StevenACoffman proposes within tomorrow.

Thank you all for the support and I hope to be back contributing in the near future.

@thenikso
Copy link
Contributor

@HyperBrain you should be all set! Please feel free to contact me privately if you need anything concerning this repo.

Also if it would be best for the community to move this repo to a new organization I am all for it.

@HyperBrain
Copy link
Member

@thenikso Thank you 🥇 . I will contact you if I have any questions or problems moving forward. Now the way should be clear to get the project to an active state again and setup a team to proceed.

Moving it to a new organization would be a goal for the next weeks then. I'll concentrate on the next steps over the upcoming weekend.

@hassankhan
Copy link
Contributor

hassankhan commented Jun 30, 2017

I'd also like to volunteer, my NPM username is the same as my GitHub one. Although I'm pressed for time currently, I have been meaning to help out for a while 😉

@ricardolpd
Copy link

Guys apologies i have been on holidays with limited internet, if you want to add me, my npm is the same as github.

@SkippyZA
Copy link

Great to see this up and running again. I landed up doing a fork of this just so I could fix some of the annoying bugs.

I will keep a tab on this and see if I can assist with contributions.

@HyperBrain
Copy link
Member

@SkippyZA 👍 Please check the recently released version 2.0.0, which contains some of the open PRs (see the release notes). Version 2.1.0 is about to be released soon (here are the planned features/fixes).

The major improvements in Version 3.0.0 are here

You're welcome to contribute. There are still a lot of issues open that could need some help 😃 . If you have fixed something and think that has to be added too, create an issue for it and (incase you already fixed it) open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants