Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless 4 Support #1923

Open
jiteshmanglani opened this issue Sep 6, 2024 · 6 comments · May be fixed by #1959
Open

Serverless 4 Support #1923

jiteshmanglani opened this issue Sep 6, 2024 · 6 comments · May be fixed by #1959

Comments

@jiteshmanglani
Copy link

This is a Bug Report

Description

For bug reports:

  • Can't install packages due to unresolved dependency
  • It should install all the packages
  • normal config
  • npm ERR! code ERESOLVE npm ERR! ERESOLVE could not resolve npm ERR! npm ERR! While resolving: serverless-webpack@5.14.1 npm ERR! Found: serverless@4.2.4 npm ERR! node_modules/serverless npm ERR! dev serverless@"^4.2.4" from the root project npm ERR! peer serverless@">=2.60" from serverless-domain-manager@7.4.0 npm ERR! node_modules/serverless-domain-manager npm ERR! dev serverless-domain-manager@"^7.4.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer serverless@"1 || 2 || 3" from serverless-webpack@5.14.1 npm ERR! node_modules/serverless-webpack npm ERR! dev serverless-webpack@"^5.14.1" from the root project npm ERR! npm ERR! Conflicting peer dependency: serverless@3.39.0 npm ERR! node_modules/serverless npm ERR! peer serverless@"1 || 2 || 3" from serverless-webpack@5.14.1 npm ERR! node_modules/serverless-webpack npm ERR! dev serverless-webpack@"^5.14.1" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Similar or dependent issue(s):

  • NA

Additional Data

  • Serverless-Webpack Version 5.14.1:
  • Webpack version 5.93.0:
  • ***Serverless Framework Version 4.2.4 ***:
  • Operating System Fedora 39:
@j0k3r
Copy link
Member

j0k3r commented Sep 6, 2024

I checked quickly and it seems the v4 file structure completely changed.

v4 only expose the binary and that's all: https://www.npmjs.com/package/serverless?activeTab=code
v3 exported usefull stuff that we are using internally: https://www.npmjs.com/package/serverless/v/3.39.0?activeTab=code

Maybe it needs a better check to see if we can find a workaround.

@vicary
Copy link
Member

vicary commented Sep 6, 2024

I've sent an email to Serverless, hopefully we get a reply soon.

@jiteshmanglani
Copy link
Author

Any update on this?

@vicary
Copy link
Member

vicary commented Sep 26, 2024

@jiteshmanglani Unfortunately no responses are received thus far.

@kevinlbatchelor
Copy link

I pinged them on the slack channel, no response

@vicary
Copy link
Member

vicary commented Oct 3, 2024

Just received this reply via email, full response quoted below.

Hi Vicary,

Apologies for the slow reply. As you can imagine we have been quite busy.

As to your question, really the only standard requirement on our side is to ensure that the npm dependancies point to serverless@4 and not v3 anymore. If there is anything else that comes up as an issue, I would recommend adding an issue on the project GitHub as that will allow everyone on the engineering team the opportunity to see the issue publicly and work with you from there: https://github.com/serverless/serverless/issues

@j0k3r j0k3r linked a pull request Oct 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants