Speed up cleanup process

[neilime]

What did you implement:

Removing ".webpack" directory may be is very slow on when this directory is huge.

How did you implement it:

• Performs remove async (no need to wait the remove of this directory before running the next process)

How can we verify it:

Run serverless deploy

Todos:

• Write tests
• Write documentation
• Fix linting errors
• Make sure code coverage hasn't dropped
• Provide verification config / commands / resources
• Enable "Allow edits from maintainers" for this PR
• Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

[neilime]

Any chance to get this PR reviewed ?

[HyperBrain]

@serverless-heaven/serverless-webpack-contributors Can someone help to review this PR? If it is ok, it will be part of 5.3.0

[designfrontier]

I'll take a look at it right now...

[designfrontier]

A few small changes and then it should be good to go. Looks great! If you wouldn't mind resolving the conflict while you are updating this patch that would be fantastic.

Thanks for your contribution!

[neilime]

@designfrontier : I've made some change tell me if it's good to you now, thank you.

[designfrontier]

Sorry for the nitpick on spaces... everything else looks amazing

[designfrontier]

one super tiny thing. Thanks for your work on this

[hassankhan]

LGTM 👍

[HyperBrain]

@designfrontier Can you finish the review and eventually merge?

[designfrontier]

Yeah I’ll take a look today

…

On Apr 14, 2019, at 07:47, Frank Schmid ***@***.***> wrote: @designfrontier Can you finish the review and eventually merge? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[hassankhan]

Just had a chance to test it on my own projects, seems to work fine but can't really tell since I don't have large deployment sizes.

[designfrontier]

LGTM

[designfrontier]

Actually... on a second look it looks like there is a new branch in the code that is untested. Details are here: https://coveralls.io/builds/23015127/source?filename=lib/cleanup.js

I think you should be able to test this by setting everything up and removing the webpack directory before you run cleanup. Then checking that you get the correct error output in the log with verbose set.

Bonus points would be testing that ternary that changes where the logs go

[j0k3r]

I've squashed all commits, added more tests to increase coverage and rebased against the release/5.4.0 branch.
I think it's ready to be merged!