Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

Commit 11c80b3

Browse files
authored
fix: Exit process when error logging into Azure (#192)
1 parent c51a865 commit 11c80b3

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/plugins/login/loginPlugin.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,18 @@ describe("Login Plugin", () => {
7878
expect(sls.variables["subscriptionId"]).toEqual("azureSubId");
7979
});
8080

81-
it("logs an error from authentication", async () => {
81+
it("logs an error from authentication and exits process", async () => {
8282
unsetServicePrincipalEnvVariables();
83+
process.exit = jest.fn() as any;
8384
const errorMessage = "This is my error message";
8485
AzureLoginService.interactiveLogin = jest.fn(() => {
8586
throw new Error(errorMessage);
86-
});
87+
});
8788
const sls = MockFactory.createTestServerless();
8889
await invokeLoginHook(false, sls);
8990
expect(AzureLoginService.interactiveLogin).toBeCalled()
9091
expect(AzureLoginService.servicePrincipalLogin).not.toBeCalled();
91-
expect(sls.cli.log).lastCalledWith(`Error: ${errorMessage}`)
92+
expect(sls.cli.log).lastCalledWith(`Error: ${errorMessage}`);
93+
expect(process.exit).toBeCalledWith(0);
9294
});
93-
})
95+
});

src/plugins/login/loginPlugin.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export class AzureLoginPlugin {
3535
catch (e) {
3636
this.serverless.cli.log("Error logging into azure");
3737
this.serverless.cli.log(`${e}`);
38+
process.exit(0);
3839
}
3940
}
4041
}

0 commit comments

Comments
 (0)