This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
feat: Azure Packaging updates #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
commented
Jun 7, 2019
tbarlow12
reviewed
Jun 10, 2019
There was a problem hiding this comment.
Looks good. We should sync on the packaging process with regards to the relative path between function.json and the handler. I made a change in my Offline Plugin PR. I have no idea why the mkdirSync spy is causing the test to fail. I've been through your changes and comparing them to my own test using the same thing, but I'll see if I can see anything else
wbreza
force-pushed
the
wabrez/package-updates
branch
from
077960b to
25212f7
Compare
|
@tbarlow12 - I found that calling |
wbreza
force-pushed
the
wabrez/package-updates
branch
from
25212f7 to
b8ef4bd
Compare
mydiemho
approved these changes
Jun 12, 2019
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
- Updates packaging strategy to write function.json into expected folder structure - Dynamically resolves handler path based on yaml definition and destination folder - Removes and cleans up function.json and function folders after packaging is completed Resolves ABA#82, 90, 89
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ABA#82, 90, 89