This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
feat: Dynamically generate ARM templates #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
force-pushed
the
wabrez/split-arm-templates
branch
from
ac07475 to
4fb18be
Compare
wbreza
commented
Jun 20, 2019
wbreza
commented
Jun 20, 2019
wbreza
commented
Jun 20, 2019
tbarlow12
approved these changes
Jun 20, 2019
pjlittle
reviewed
Jun 20, 2019
|
Good stuff -- like the flexibility of options. |
pjlittle
approved these changes
Jun 20, 2019
wbreza
force-pushed
the
wabrez/split-arm-templates
branch
from
dc5028e to
86c3bc7
Compare
wbreza
force-pushed
the
wabrez/split-arm-templates
branch
from
7293a1d to
c49b66c
Compare
wbreza
changed the title
mydiemho
reviewed
Jun 21, 2019
tbarlow12
approved these changes
Jun 21, 2019
| @@ -33,7 +35,7 @@ describe("Function App Service", () => { | |||
|
|
|||
| beforeAll(() => { | |||
|
|
|||
| // TODO: How to spy on defaul exported function? | |||
| // TODO: How to spy on default exported function? | |||
There was a problem hiding this comment.
Remove this. Pretty sure I added it, but I don't think it's needed
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
Based on various well-known skus we can generate ARM templates with the correct resources and expose parameters. Well Known variations: - Consumption - Premium - AppServiceEnvironment Consolidate ARM template deployment strategy into ArmService
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on various well-known skus we can generate ARM templates with the correct resources and expose parameters.
Well Known variations:
Consolidate ARM template deployment strategy into ArmService