Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

feat: add support for specifying resourceGroup in both cli and yaml #189

Merged
merged 2 commits into from
Jul 5, 2019

Conversation

mydiemho
Copy link
Contributor

@mydiemho mydiemho commented Jul 3, 2019

when a name is specified in cli or yaml, serverless will use this name to create the resourceGroup instead of creating a name from convention.

all underlying resources will still be created with a convention name.

Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple minor comments.

src/plugins/deploy/azureDeployPlugin.ts Outdated Show resolved Hide resolved
src/services/baseService.test.ts Show resolved Hide resolved
src/services/baseService.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tbarlow12 tbarlow12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydiemho mydiemho merged commit 691a4af into dev Jul 5, 2019
@mydiemho mydiemho deleted the myho/resourceFlag branch July 5, 2019 16:59
tbarlow12 pushed a commit that referenced this pull request Sep 13, 2019
…189)

when a name is specified in cli or yaml, serverless will use this name to create the resourceGroup instead of creating a name from convention.

all underlying resources will still be created with a convention name.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants