Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

feat: List deployments for rollback when no timestamp given #208

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

tbarlow12
Copy link
Contributor

Rollback requires a timestamp. Rather than forcing users to run sls deploy list to generate the deployments they can choose from, sls rollback with no args also generates the same list.

Resolves [AB#493]

@tbarlow12 tbarlow12 requested review from wbreza and neerajmandal July 19, 2019 17:23
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@neerajmandal neerajmandal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks greats

@tbarlow12 tbarlow12 force-pushed the tabarlow/rollback-deploys branch from 566092a to 89ac6ab Compare July 19, 2019 17:57
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 83.941% when pulling 89ac6ab on tabarlow/rollback-deploys into 2b97f75 on dev.

@tbarlow12 tbarlow12 merged commit 9b7bb74 into dev Jul 22, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/rollback-deploys branch July 22, 2019 12:51
tbarlow12 added a commit that referenced this pull request Sep 13, 2019
Rollback requires a timestamp. Rather than forcing users to run `sls deploy list` to generate the deployments they can choose from, `sls rollback` with no args also generates the same list.

Resolves [AB#493]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants