Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

feat: Path from x-azure-settings is included in function.json #212

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

tbarlow12
Copy link
Contributor

In serverless.yml, you can now specify an API route within x-azure-settings, which will be added to the function.json file.

Resolves [AB#552]

@tbarlow12 tbarlow12 requested review from mydiemho, wbreza and PIC123 July 23, 2019 19:45
@coveralls
Copy link

coveralls commented Jul 23, 2019

Coverage Status

Coverage increased (+0.2%) to 84.432% when pulling 76a7170 on tabarlow/path-package into 1c8e5bf on dev.

const expectedFunctionJson = {
entryPoint: "handler",
scriptFile: "src/handlers/hello",
route: "myRoute",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in the event level

Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than My's comment, looks good

@tbarlow12 tbarlow12 merged commit dcb7c9f into dev Jul 24, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/path-package branch July 24, 2019 14:11
tbarlow12 added a commit that referenced this pull request Sep 13, 2019
In serverless.yml, you can now specify an API route within `x-azure-settings`, which will be added to the `function.json` file.

Resolves [AB#552]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants