This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
fix: Add retry support when listing deployed functions #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
suggested changes
Jul 30, 2019
pjlittle
reviewed
Aug 1, 2019
|
One small comment, otherwise LGTM! Hopefully this helps w/ some of the flakiness we've seen |
pjlittle
approved these changes
Aug 1, 2019
wbreza
force-pushed
the
wabrez/async-retry
branch
from
7866663 to
c5b28b6
Compare
mydiemho
reviewed
Aug 2, 2019
| const serverlessFunctions = this.serverless.service.getAllFunctions(); | ||
| const deployedFunctions = await this.listFunctions(functionApp); | ||
|
|
||
| // List functions that are part of the serverless yaml config |
There was a problem hiding this comment.
will there ever be a use case where there are deployed functions that are not in the yamL?
mydiemho
approved these changes
Aug 2, 2019
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
When listing the deployed functions on 1st time deployment it may take some additional time to initialize the function app and extract the functions. This adds a retry policy that will retry the function listing multiple times until the function app is fully ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing the deployed functions on 1st time deployment it may take some additional time to initialize the function app and extract the functions. This adds a retry policy that will retry the function listing multiple times until the function app is fully ready.