This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
fix: Use stage, region, resourceGroup and prefix from CLI options #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
approved these changes
Aug 29, 2019
| * Overwrite values for resourceGroup, prefix, region and stage | ||
| * in config if passed through CLI | ||
| */ | ||
| private setConfigFromCli() { |
wbreza
approved these changes
Aug 29, 2019
src/services/namingService.ts
Outdated
|
|
||
| const stageMap = { | ||
| "dogfood": "df", | ||
| "df": "df", |
tbarlow12
force-pushed
the
tabarlow/stage-name
branch
from
de3b249 to
b321dfa
Compare
tbarlow12
added a commit
that referenced
this pull request
Aug 30, 2019
Fixes a regression in accepting `region` and `stage` options from CLI to form resource group name. Adds acceptance of `prefix` as well. Does so by configuring each of them in `serverless.service` (`ServerlessAzureConfig`) as one of the first steps of the `BaseService` constructor. Also puts `location` into `region` inside the config if `location` is specified, but `region` is not. Resolves #280, #282 and #281
tbarlow12
added a commit
that referenced
this pull request
Sep 13, 2019
Fixes a regression in accepting `region` and `stage` options from CLI to form resource group name. Adds acceptance of `prefix` as well. Does so by configuring each of them in `serverless.service` (`ServerlessAzureConfig`) as one of the first steps of the `BaseService` constructor. Also puts `location` into `region` inside the config if `location` is specified, but `region` is not. Resolves #280, #282 and #281
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in accepting
regionandstageoptions from CLI to form resource group name. Adds acceptance ofprefixas well. Does so by configuring each of them inserverless.service(ServerlessAzureConfig) as one of the first steps of theBaseServiceconstructor.Also puts
locationintoregioninside the config iflocationis specified, butregionis not.Resolves #280, #282 and #281