This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Create default .azure directory if not present #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbreza
approved these changes
Sep 6, 2019
| private subscriptions: any[] = []; | ||
|
|
||
| public constructor(private tokenPath: string = DEFAULT_SLS_TOKEN_FILE) { | ||
| if(tokenPath === DEFAULT_SLS_TOKEN_FILE && !fs.existsSync(CONFIG_DIRECTORY)) { |
Contributor
There was a problem hiding this comment.
nit: spacing - Run auto-format
tbarlow12
approved these changes
Sep 9, 2019
Contributor
tbarlow12
left a comment
tbarlow12
left a comment
There was a problem hiding this comment.
LGTM, looks like your tests are failing on Windows, though
tbarlow12
force-pushed
the
phcherne/fix-interactive-login
branch
from
2c013ca to
d9c7aec
Compare
wbreza
suggested changes
Sep 10, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Let's get the tests fixed first.
wbreza
force-pushed
the
phcherne/fix-interactive-login
branch
from
ba288cb to
8fad3a2
Compare
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
* Check for .azure directory * Add test * Add recursion to make local .azure folder * Mock os to fix widnows test * Attempt to fixd windows test with mock * Fixing tests, still failing to mkdir * Fix test by resetting filepath in token constructor * Fix test withmockRestore * test: Updated token cache tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Create default .azure directory if not present
The pluging currently saves credentials from interactive login in the .azure directory by default. If the user doesn't have a .azure directory, current;y the plugin hits an error. This fix checks to make sure the .azure directory exists and creates it if not.
Closes #317