Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

fix: Exclude ARM params with null values #325

Merged
merged 1 commit into from
Sep 9, 2019
Merged

fix: Exclude ARM params with null values #325

merged 1 commit into from
Sep 9, 2019

Conversation

tbarlow12
Copy link
Contributor

  • Eliminate explicit type from valued paramaters
  • Remove any parameters whose value is null before deployment
  • Make type optional on ArmParameters

PIC123
PIC123 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@PIC123 PIC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, simplifies things nicely

wbreza
wbreza approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - Let's see if there is a way we can protect from introducing a change like this in the future.

src/services/armService.ts Outdated
@@ -102,6 +102,12 @@ export class ArmService extends BaseService {
return;
}

for (const key of Object.keys(deployment.parameters)) {
if (!deployment.parameters[key].value) {
deployment.parameters[key] = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete the param using the following: delete deployment.parameters[key];

@tbarlow12 tbarlow12 force-pushed the tabarlow/resource-type branch from 9d8cbe5 to 9d776ee Compare September 9, 2019 21:19
@tbarlow12 tbarlow12 merged commit 1068a4b into dev Sep 9, 2019
@tbarlow12 tbarlow12 deleted the tabarlow/resource-type branch September 9, 2019 21:26
tbarlow12 added a commit that referenced this pull request Sep 13, 2019
@tbarlow12
fix: Exclude ARM params with null values (#325)
8c01f62 
- [x] Eliminate explicit `type` from valued paramaters
- [x] Remove any parameters whose value is `null` before deployment
- [x] Make `type` optional on `ArmParameters`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PIC123 PIC123 PIC123 approved these changes

@wbreza wbreza wbreza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbarlow12 @wbreza @PIC123