Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

fix: Remove -v shortcut for --verbose, conflicts with --version #435

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

tbarlow12
Copy link
Contributor

What did you implement:

Currently, if you were to run sls --version or sls -v, the plugin causes it to fail because the LoggingService creates a shortcut for --verbose, which is -v. This conflicts with --version. This PR removes that shortcut and updates the documentation.

How did you implement it:

Only look for the full verbose flag within the options, set log level to info if undefined.

How can we verify it:

Run sls --version. It shouldn't fail.

Todos:

Note: Run npm run test:ci to run all validation checks on proposed changes

  • Ensure there are no lint errors.
    Validate via npm run lint
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pjlittle
Copy link
Contributor

LGTM - thanks for fixing, we definitely shouldn't be stomping/failing on this.

@tbarlow12 tbarlow12 merged commit c0b1666 into dev Apr 21, 2020
@tbarlow12 tbarlow12 deleted the tbarlow12/fix-logging-service branch April 30, 2020 13:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants