fix: Log functions in external deployment #456

tbarlow12 · 2020-05-18T17:34:28Z

What did you implement:

In external deployment (always the case for .NET on linux), the deployed functions were not listed in the publishing process. This PR adds that fix.

Deploy a function app with provider.deployment.external set to true in serverless.yml
You should see the functions listed after publishing

Note: Run npm run test:ci to run all validation checks on proposed changes

Ensure there are no lint errors.
Validate via npm run lint
Note: Some reported issues can be automatically fixed by running npm run lint:fix
Write tests and confirm existing functionality is not broken.
Validate via npm test
Write documentation
Provide verification config / commands / resources
Enable "Allow edits from maintainers" for this PR
Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

wbreza

LGTM - I'd recommend adding a unit test to validate this change.

wbreza · 2020-05-18T17:41:59Z

src/services/functionAppService.ts

      await this.syncTriggers(functionApp, response.properties);
+      await this.logFunctions(functionApp);


Unit test to validate this change?

fix: Log functions in external deployment

21807b7

tbarlow12 requested a review from wbreza May 18, 2020 17:35

wbreza approved these changes May 18, 2020

View reviewed changes

test: Add unit tests

c0820f2

tbarlow12 merged commit 379ebdb into dev May 18, 2020

tbarlow12 deleted the tbarlow12/log-functions branch May 20, 2020 17:07

		await this.syncTriggers(functionApp, response.properties);
		await this.logFunctions(functionApp);