Slim functionality failing on Windows

[sweepy84]

Slim functionality not working at all on windows.
Still getting test folders >> https://snag.gy/g5SelK.jpg

Using the following options:

custom:
    pythonRequirements:
      slim: true
      slimPatterns:
        - "*test*"
        - "*.exe"
      pythonBin: python
      dockerizePip: true

Issue has been noted here by @dee-me-tree-or-love

[sweepy84]

@dschep @dee-me-tree-or-love - Any updates on this?

[dschep]

Huh.. I thought it was supposed to work with docker @dee-me-tree-or-love ?

[sweepy84]

@dschep Nope - as per comments in #191 completely busted for windows

[dee-me-tree-or-love]

Hey everyone, huge apologies, I have been totally out for the past months of the summer...

Now I finally got back to look into the problem and have noticed something interesting.
I am currently using the "serverless-python-requirements": "^4.1.1" version.
I have removed the windows check at slim.js :: L15

While trying out to deploy I have noticed that when run with slim: true and dockerizePip: true on Windows 10 (will yet try it out on a Linux later) I have also received the error:

find: missing argument to `-exec'

Then, when reviewing the console commands for package removal noticed that
changing `&& find ${folderPath} -name "*.so" -exec strip {} \\;`,
to `&& find ${folderPath} -name "*.so" -exec strip {} ;`
at slim.js :: L38 solves the issue 🤔.

So I have tried to escape the semicolon using the backslashes, which appaaaarently might not be necessary... Not sure if that was the whole deal, but could someone try it out too maybe? 😅

Sorry again for not keeping up for so long...
Node version: v8.11.1
Serverless version: 1.27.3
My serverless.yml

plugins:
  - serverless-python-requirements
  
custom:
  pythonRequirements:
    dockerizePip: non-linux
    # zip: true
    slim: true

@sweepy84 @dschep

[dschep]

@dee-me-tree-or-love, check out #227

[dee-me-tree-or-love]

@dschep oh cool, on it!

[sweepy84]

It works!!! good job @dee-me-tree-or-love !