Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support to v0.8 #70

Closed
brlala opened this issue Sep 7, 2022 · 22 comments · Fixed by #84
Closed

Update support to v0.8 #70

brlala opened this issue Sep 7, 2022 · 22 comments · Fixed by #84
Assignees
Labels
enhancement 🙏 New feature or request Stale Issue

Comments

@brlala
Copy link
Contributor

brlala commented Sep 7, 2022

What would you like to be added:
Update to v0,8

Why is this needed:
V0.8 has lots of new enhancements like async subflow and custom function. All other SDK has already been updated, should this be done as well?

@brlala brlala added the enhancement 🙏 New feature or request label Sep 7, 2022
@ricardozanini
Copy link
Member

@brlala, it's on our roadmap to upgrade. We are looking for contributions :)

@ricardozanini ricardozanini added this to the Spec 0.8 Support milestone Sep 8, 2022
@lsytj0413
Copy link
Collaborator

@ricardozanini I'd like to take care of this, because I am reviewing all the existing verifications, relevant to this feature.

@ricardozanini
Copy link
Member

@lsytj0413 that's perfectly fine from my side.

@spolti
Copy link
Member

spolti commented Sep 21, 2022

Hi all, I'll he helping on this task in the next few days.

The spec for reference: https://github.com/serverlessworkflow/specification/tree/0.8.x/roadmap#-release-version-08

The table below is to help us to track what needs to be completed:

Status Description PR
✔️ Support custom function type definition #80
✔️ Workflow "name" no longer a required property #81
✔️ Workflow "start" no longer a required property #84
✔️ ForEach state "iterationParam" no longer a required property #85
✔️ Added "useData" for eventDataFilter, and "useResults" for actionDataFilter #79, #82
✔️ Added "resultEventTimeout" for action eventref #90
✔️ Added example for "continueAs" #92
✔️ Support for async action invocation #93
✔️ Support for action condition #83

If there is a task already added, please let me know. If possible attach the pull request in this issue.

Thanks.

@lsytj0413
Copy link
Collaborator

@spolti I'm working on Added "useData" for eventDataFilter, and "useResults" for actionDataFilter

@spolti
Copy link
Member

spolti commented Sep 22, 2022

Thanks for the update @lsytj0413.

@spolti
Copy link
Member

spolti commented Sep 27, 2022

@lsytj0413 for the item you was working on, in the PR that was merged you have added only the useData, are you going to send another pr for the useResults field?

@lsytj0413
Copy link
Collaborator

@lsytj0413 for the item you was working on, in the PR that was merged you have added only the useData, are you going to send another pr for the useResults field?

Yep, i'm working on another PR to add useResults field.

@spolti
Copy link
Member

spolti commented Sep 30, 2022

probably closed by my mistake :D
@ricardozanini can you please re-open?

@spolti
Copy link
Member

spolti commented Oct 3, 2022

For the Added example for "continueAs" item, there isn't much to do, however there is no test to validate it.
While adding a test it turns out that the data field is always nil, for example:

 - name: CheckEventQuota
   type: switch
   dataConditions:
    - condition: "${ try(.customerCount) != null and .customerCount > .quota.maxConsumedEvents
      }"
      end:
       continueAs:
        workflowId: notifycustomerworkflow
        version: '1.0'
        data: "${ del(.customerCount) }"

I am looking over it to figure out why.

@spolti
Copy link
Member

spolti commented Oct 5, 2022

All tasks done.
Thanks very much everyone for the effort put on this. :)

@ricardozanini
Copy link
Member

@spolti, I think we can add more test cases using workflows from v0.8 to ensure we are all set. Also, if you are working on an implementation, can you please try your use cases with the latest commit and report back?

@lsytj0413 same thing, please.

So that I can work on a new release by the end of this week. :)

@spolti
Copy link
Member

spolti commented Oct 6, 2022

@ricardozanini do you mean a v8 file that contains all v08 additions?
@davidesalerno can you please try it with the operator you are working on?

@ricardozanini
Copy link
Member

@spolti maybe looking for examples updated with v0.8: https://github.com/serverlessworkflow/specification/tree/0.8.x/examples

@spolti
Copy link
Member

spolti commented Oct 10, 2022

a few fixes: #104

@spolti
Copy link
Member

spolti commented Oct 24, 2022

@ricardozanini it seems that we are ready to release the v08 and close this issue :)

@spolti
Copy link
Member

spolti commented Oct 24, 2022

Actually, I need to finish this one first #111

@lsytj0413
Copy link
Collaborator

@ricardozanini all task have done, could you please release the v0.8 version?

@ricardozanini
Copy link
Member

@spolti @lsytj0413 @brlala are you guys happy with the latest commit in your use cases?

@spolti
Copy link
Member

spolti commented Nov 18, 2022

@ricardozanini maybe there is just one thing, the deepcopy stuff, not critical though.

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@spolti
Copy link
Member

spolti commented Jan 3, 2023

@ricardozanini I think we can close this one, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment