Fix state execution timeout schema and text (#564)

* Fix state execution timeout schema and text

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

* update

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

* Update specification.md

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

Co-authored-by: Ricardo Zanini <1538000+ricardozanini@users.noreply.github.com>

Author: tsurdilo

roadmap/README.md

@@ -24,6 +24,7 @@ _Status description:_
 | Status | Description | Comments |
 | --- | --- |  --- |
 | ✔️| Fix support for workflow extensions | [spec doc](https://github.com/serverlessworkflow/specification/blob/main/specification.md)  |
+| ✔️| Fix state execution timeout | [spec doc](https://github.com/serverlessworkflow/specification/blob/main/specification.md)  |
 | ✏️️| Add inline state defs in branches |   |
 | ✏️️| Update rest function definition |   |
 | ✏️️| Add "completedBy" functionality |   |

schema/timeouts.json

@@ -73,40 +73,18 @@
       ]
     },
     "stateExecTimeout": {
-      "oneOf": [
-        {
-          "type": "string",
-          "description": "Total state execution timeout (including retries) (ISO 8601 duration format)",
-          "minLength": 1
-        },
-        {
-          "type": "object",
-          "description": "Workflow default timeouts",
-          "properties": {
-            "single": {
-              "type": "string",
-              "description": "Single state execution timeout, not including retries (ISO 8601 duration format)",
-              "minLength": 1
-            },
-            "total": {
-              "type": "string",
-              "description": "Total state execution timeout, including retries (ISO 8601 duration format)",
-              "minLength": 1
-            }
-          },
-          "additionalProperties": false,
-          "required": ["total"]
-        }
-      ]
+      "type": "string",
+      "description": "Workflow state execution timeout duration (ISO 8601 duration format)",
+      "minLength": 1
     },
     "actionExecTimeout": {
       "type": "string",
-      "description": "Single actions definition execution timeout duration (ISO 8601 duration format)",
+      "description": "Action execution timeout duration (ISO 8601 duration format)",
       "minLength": 1
     },
     "branchExecTimeout": {
       "type": "string",
-      "description": "Single branch execution timeout duration (ISO 8601 duration format)",
+      "description": "Branch execution timeout duration (ISO 8601 duration format)",
       "minLength": 1
     },
     "eventTimeout": {

specification.md

@@ -5460,9 +5460,9 @@ If `object` type, it is used to define the timeout definitions in-line and has t
 | Parameter | Description | Type | Required |
 | --- | --- | --- | --- |
 | workflowExecTimeout | Workflow execution timeout (ISO 8601 duration format) | string or object | no |
-| stateExecTimeout | Default workflow state execution timeout (ISO 8601 duration format) | string or object | no |
-| actionExecTimeout | Default single actions definition execution timeout (ISO 8601 duration format) | string | no |
-| branchExecTimeout | Default single branch execution timeout (ISO 8601 duration format) | string | no |
+| stateExecTimeout | Workflow state execution timeout (ISO 8601 duration format) | string or object | no |
+| actionExecTimeout | Actions execution timeout (ISO 8601 duration format) | string | no |
+| branchExecTimeout | Branch execution timeout (ISO 8601 duration format) | string | no |
 | eventTimeout | Default timeout for consuming defined events (ISO 8601 duration format) | string | no |
 
 The `eventTimeout` property defines the maximum amount of time to wait to consume defined events. If not specified it should default to
@@ -5552,27 +5552,11 @@ timeout settings are available for each state type.
 
 Workflow states timeouts cannot define the `workflowExecTimeout` property.
 
-All workflow states can define the `stateExecTimeout` property. This property can have two types, namely string 
-and object.
-If defined as string type, it defines the total state execution timeout, including any [retries](#Retry-Definition) 
-as defined in the states retry policy.
-If defined as object type it has the following properties:
-
-| Parameter | Description | Type | Required |
-| --- | --- | --- | --- |
-| single | Single state execution timeout, not including retries (ISO 8601 duration format) | string | no |
-| total | Total state execution timeout, including retries (ISO 8601 duration format)  | string | yes |
-
-The `single` property defines a single state execution timeout. This property does not take in account retries.
-Each time the state is executed, whether when it is executes as part of standard control flow logic, or as part of a retry,
-its total execution timeouts is the value of the `single` property. 
-To show an example, let's say that we set the `single`
-property to "PT10S", meaning 10 seconds. A workflow state "X" which defines this timeout when first executed has the max execution timeout 
-set to 10 seconds. If the state execution is then retried, each time it is retried, the individual retry max execution timeout is again 10 seconds.
-
-The `total` property on the other hand defines a state execution timeout taking in account retries.
-This means when this state is executed, its execution timeout is the value of the `total` property no matter how many retries
-have to be performed. If a state execution includes zero or one hundred retries, the total execution timeout is set by this property.
+Workflow states can set their `stateExecTimeout` property inside the `timeouts` definition. 
+The value of this property is a time duration (ISO 8601 duration format). 
+It must be a duration that's greater than zero and defines the total state execution timeout. 
+When this timeout is reached, state execution
+should be stopped and can be handled as a timeout error in the states `onErrors` definition.
 
 #### Branch Timeout Definition