Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename eventDef correlation properties #679

Closed
cdavernas opened this issue Sep 14, 2022 · 8 comments
Closed

Rename eventDef correlation properties #679

cdavernas opened this issue Sep 14, 2022 · 8 comments
Labels
area: spec Changes in the Specification change: feature New feature or request. Impacts in a minor version change
Milestone
v0.9.0

Comments

@cdavernas
Copy link
Member

What would you like to be added:

Rename the eventDef's correlation object properties to have something shorter, as explicit, and cleaner IMHO.

Currently, we have:

...
events:
- name: MyEvent
  kind: consumed
  source: ...
  type: ...
  correlation:
  - contextAttributeName: ...
    contextAttributeValue: ...
...

What I propose is to have:

...
events:
- name: MyEvent
  kind: consumed
  source: ...
  type: ...
  correlation:
  - name: ...
    value: ...
...

Why is this needed:

Shorter, cleaner, easier to write without typo/casing mistake, self-explainatory
@cdavernas cdavernas added change: feature New feature or request. Impacts in a minor version change area: spec Changes in the Specification schema labels Sep 14, 2022
@ricardozanini
Copy link
Member

+1

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@lsytj0413
Copy link
Contributor

/remove-stale

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as completed Apr 7, 2023
@ricardozanini ricardozanini reopened this Apr 27, 2023
@ricardozanini ricardozanini added this to the v0.9 milestone May 25, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@cdavernas
Copy link
Member Author

cdavernas commented May 17, 2024 •
edited by ricardozanini
Loading

This has been addressed in 1.0.0-alpha1, and is closed as part of #843

This was referenced May 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: spec Changes in the Specification change: feature New feature or request. Impacts in a minor version change
Projects
Progress Tracker
Status: Done
Milestone
v0.9.0
Development

No branches or pull requests
3 participants
@ricardozanini @lsytj0413 @cdavernas