Operator ignores the configured Runner tag

[bvandewe]

What happened:

When trying to test the latest runner:1.0.0-alpha1, the operator was manually configured to use the tagged runner:1.0.0-alpha1 but resulting workflow instances still used the runner:latest (which isnt the same image).

IOW, manually setting the runner image doesnt resolve the issue (even after restarting the operator):

PATCH http://localhost:8080/api/v1/operators/default/operator-1

{
  "type": "patch",
  "document": [
    {
      "op": "replace",
      "path": "/spec/runner/runtime/container/image",
      "value": "ghcr.io/serverlessworkflow/synapse/runner:1.0.0-alpha1"
    }
  ]
}

Manually pulling and tagging the image runner:1.0.0-alpha1 as runner:latest solves this and workflow instances start and execute as expected...

apiVersion: synapse.io/v1
kind: Operator
metadata:
  name: operator-1
  namespace: default
  creationTimestamp: 2024-09-05T06:49:55.5802410+00:00
  generation: 2
  resourceVersion: 520B0704
spec:
  runner:
    api:
      uri: http://api:8080
    runtime:
      container:
        image: ghcr.io/serverlessworkflow/synapse/runner:1.0.0-alpha1
status:
  phase: running

docker container ls
CONTAINER ID   IMAGE                                                        COMMAND                  CREATED              STATUS              PORTS                    NAMES
c41f58fc234f   ghcr.io/serverlessworkflow/synapse/runner                    "dotnet Synapse.Runn…"   7 seconds ago        Up 7 seconds                                 sad_diffie
2158ee35749a   ghcr.io/serverlessworkflow/synapse/correlator:1.0.0-alpha1   "dotnet Synapse.Corr…"   About a minute ago   Up About a minute   0.0.0.0:8081->8080/tcp   synapse-correlator-1
6e57415d1756   ghcr.io/serverlessworkflow/synapse/operator:1.0.0-alpha1     "dotnet Synapse.Oper…"   About a minute ago   Up About a minute                            synapse-operator-1
c50d0590e1fc   ghcr.io/serverlessworkflow/synapse/api:1.0.0-alpha1          "dotnet Synapse.Api.…"   About a minute ago   Up About a minute   0.0.0.0:8080->8080/tcp   synapse-api-1
5f768bbc5c45   ghcr.io/microsoft/garnet                                     "/app/GarnetServer"      About a minute ago   Up About a minute   6379/tcp                 synapse-garnet-1

# docker images | grep synapse
ghcr.io/serverlessworkflow/synapse/api                                                    1.0.0-alpha1   a50d78a94c74   22 hours ago    344MB
ghcr.io/serverlessworkflow/synapse/runner                                                 1.0.0-alpha1   7b00efa866e1   22 hours ago    383MB
ghcr.io/serverlessworkflow/synapse/operator                                               1.0.0-alpha1   726450a4fdc8   22 hours ago    230MB
ghcr.io/serverlessworkflow/synapse/correlator                                             1.0.0-alpha1   1dc52ed795df   22 hours ago    257MB
ghcr.io/serverlessworkflow/synapse/api                                                    latest         342abb1a15c5   2 days ago      344MB
ghcr.io/serverlessworkflow/synapse/operator                                               latest         3ecad7f7ce0b   2 days ago      230MB
ghcr.io/serverlessworkflow/synapse/runner                                                 1.1            59d293fc3b8c   2 days ago      383MB
ghcr.io/serverlessworkflow/synapse/runner                                                 1.1.0          59d293fc3b8c   2 days ago      383MB
ghcr.io/serverlessworkflow/synapse/runner                                                 latest         59d293fc3b8c   2 days ago      383MB
ghcr.io/serverlessworkflow/synapse/correlator                                             latest         9b6c382b68b8   2 days ago      257MB

# docker pull  ghcr.io/serverlessworkflow/synapse/runner:1.0.0-alpha1
1.0.0-alpha1: Pulling from serverlessworkflow/synapse/runner
Digest: sha256:c80b2b82d3eb4327477b890b3deb0836db3dfc8a6032624a7b0474de8f128938
Status: Image is up to date for ghcr.io/serverlessworkflow/synapse/runner:1.0.0-alpha1
ghcr.io/serverlessworkflow/synapse/runner:1.0.0-alpha1
...

# docker tag ghcr.io/serverlessworkflow/synapse/runner:1.0.0-alpha1 ghcr.io/serverlessworkflow/synapse/runner

# docker images | grep synapse
ghcr.io/serverlessworkflow/synapse/api                                                    1.0.0-alpha1   a50d78a94c74   22 hours ago    344MB
ghcr.io/serverlessworkflow/synapse/runner                                                 1.0.0-alpha1   7b00efa866e1   22 hours ago    383MB
ghcr.io/serverlessworkflow/synapse/runner                                                 latest         7b00efa866e1   22 hours ago    383MB <<<<<<<<
ghcr.io/serverlessworkflow/synapse/operator                                               1.0.0-alpha1   726450a4fdc8   22 hours ago    230MB
ghcr.io/serverlessworkflow/synapse/correlator                                             1.0.0-alpha1   1dc52ed795df   22 hours ago    257MB
ghcr.io/serverlessworkflow/synapse/api                                                    latest         342abb1a15c5   2 days ago      344MB
ghcr.io/serverlessworkflow/synapse/operator                                               latest         3ecad7f7ce0b   2 days ago      230MB
ghcr.io/serverlessworkflow/synapse/runner                                                 1.1            59d293fc3b8c   2 days ago      383MB
ghcr.io/serverlessworkflow/synapse/runner                                                 1.1.0          59d293fc3b8c   2 days ago      383MB
ghcr.io/serverlessworkflow/synapse/correlator                                             latest         9b6c382b68b8   2 days ago      257MB

What you expected to happen:

The Operator could take the configured Runner' image into account.

How to reproduce it:

See above.

Anything else we need to know?:

Environment: