Skip to content

Improve workflow existence check to prevent misleading 404 logs #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JBBianchi opened this issue Dec 5, 2024 · 0 comments · Fixed by #469
Closed

Improve workflow existence check to prevent misleading 404 logs #457

JBBianchi opened this issue Dec 5, 2024 · 0 comments · Fixed by #469
Assignees
Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: enhancement New feature or request weight: 1 An issue that has a very low development impact
Milestone

Comments

@JBBianchi
Copy link
Member

What would you like to be added:
Explore alternative ways to check workflow existence that do not rely on a 404 response.

Why is this needed:
In the component used for creating or updating a "workflow," a server query is made upon user submission to determine if the workflow already exists. This determines whether to proceed with an update or a creation.

However, when the workflow does not exist (i.e., a creation scenario), the server responds with a 404, which generates a misleading log entry. While the functionality works as intended, the 404 response could be avoided to reduce noise in the logs and improve clarity.

@JBBianchi JBBianchi added type: enhancement New feature or request app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue weight: 1 An issue that has a very low development impact labels Dec 5, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Dec 5, 2024
@JBBianchi JBBianchi self-assigned this Dec 5, 2024
@cdavernas cdavernas changed the title Improve workflow existence check to orevent misleading 404 logs Improve workflow existence check to prevent misleading 404 logs Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Progress Tracker Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: enhancement New feature or request weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant