Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amplitude.getAnalyser() returning null #403

Open
feemcgill opened this issue Jan 18, 2020 · 5 comments
Open

Amplitude.getAnalyser() returning null #403

feemcgill opened this issue Jan 18, 2020 · 5 comments
Assignees
Labels
Bug: Confirmed 🐛 Bugs that have been replicated and need to be addressed.

Comments

@feemcgill
Copy link

Issue description

getAnalyser() returns null unless

<div class="amplitude-wave-form"></div>
Or
<div class="amplitude-visualization"></div>
Are present on the page.

I had removed my waveform due to this IOS issue #389

And now my analyser is broke!

Environment

Chrome: https://whatsmybrowser.org/b/JS36SQH

  • Amplitude.js Version: "5.0.2"

What is expected?

Would love to get the analyser on its own without waveform or AmplitudeJS registered visualization

Link to where issue can be reproduced

Additional details / screenshots

Screen Shot 2020-01-17 at 4 19 09 PM

@feemcgill feemcgill added the Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated. label Jan 18, 2020
@danpastori
Copy link
Contributor

Ah okay, AmplitudeJS only initializes the analyser if there is a use for it: https://github.com/521dimensions/amplitudejs/blob/master/src/fx/fx.js#L43. There were issues with the Web Audio API breaking other situations where devs weren't even using it, so I scoped it only if they needed it.

Let me run some tests to see if just initializing it without connecting to the source causes issues.

@danpastori danpastori added Bug: Confirmed 🐛 Bugs that have been replicated and need to be addressed. and removed Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated. labels Sep 23, 2020
@ShlokJswl
Copy link

Hi @danpastori if someone is not working on it and its still requires some help can you assign this to me?

@jaydrogers
Copy link
Member

@ShlokJswl: Thanks for chiming in.

@danpastori's been busy writing our new book, so unfortunately that means AmplitudeJS won't get updates until later in 2023.

You can see his latest efforts here: #514

@ShlokJswl
Copy link

@ShlokJswl: Thanks for chiming in.

@danpastori's been busy writing our new book, so unfortunately that means AmplitudeJS won't get updates until later in 2023.

You can see his latest efforts here: #514

@jaydrogers Hello Jay, thanks for the info, is it still okay for me to work on this issue if it's not fixed?

@jaydrogers
Copy link
Member

I would suggest to start working on it only if @danpastori says so.

There are so many changes in Amplitude 6, I'd hate to have you go through the work and not have it get released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Confirmed 🐛 Bugs that have been replicated and need to be addressed.
Projects
None yet
Development

No branches or pull requests

4 participants