Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4-rc support #397

Open
1 task
jaydrogers opened this issue Jul 10, 2024 · 1 comment
Open
1 task

Add PHP 8.4-rc support #397

jaydrogers opened this issue Jul 10, 2024 · 1 comment
Assignees
Labels
🥶 Bug: Upstream Dependency Bugs that affect this project, but need to be fixed in an upsteam library. ⚡️ Enhancement Items that are new features requested to be added. ✋ Status: Blocked This item requires something else to be completed first.

Comments

@jaydrogers
Copy link
Member

jaydrogers commented Jul 10, 2024

Background

PHP images are now available for 8.4-rc (https://hub.docker.com/_/php/tags?page=&page_size=&ordering=&name=8.4-rc)

Proposed Solution

  • Add 8.4-rc support to all image variations to prepare for 8.4 availability
@jaydrogers jaydrogers added the ⚡️ Enhancement Items that are new features requested to be added. label Jul 10, 2024
@jaydrogers jaydrogers self-assigned this Jul 10, 2024
@jaydrogers
Copy link
Member Author

I attempted to do this today, but I ran into a dependency issue. It looks like the redis extension has some dependency issues with 8.4:

37.41  cc -I. -I/tmp/pear/temp/redis -I/usr/local/include/php -I/usr/local/include/php/main -I/usr/local/include/php/TSRM -I/usr/local/include/php/Zend -I/usr/local/include/php/ext -I/usr/local/include/php/ext/date/lib -I/usr/local/include/php/ext -I/tmp/pear/temp/pear-build-defaultuseretqhtq4cbmoscHhmRO3/redis-6.0.2/liblzf -I/tmp/pear/temp/redis/liblzf -DHAVE_CONFIG_H -g -O2 -D_GNU_SOURCE -DZEND_COMPILE_DL_EXT=1 -c /tmp/pear/temp/redis/library.c -MMD -MF library.dep -MT library.lo  -fPIC -DPIC -o .libs/library.o
37.64 /tmp/pear/temp/redis/redis.c:30:10: fatal error: standard/php_random.h: No such file or directory
37.64    30 | #include <standard/php_random.h>
37.64       |          ^~~~~~~~~~~~~~~~~~~~~~~
37.64 compilation terminated.
37.64 make: *** [Makefile:204: redis.lo] Error 1
37.64 make: *** Waiting for unfinished jobs....
37.67 /tmp/pear/temp/redis/library.c:59:10: fatal error: ext/standard/php_rand.h: No such file or directory
37.67    59 | #include <ext/standard/php_rand.h>
37.67       |          ^~~~~~~~~~~~~~~~~~~~~~~~~
37.67 compilation terminated.
37.67 make: *** [Makefile:210: library.lo] Error 1
39.77 ERROR: `make -j10' failed
------

@jaydrogers jaydrogers added the 🥶 Bug: Upstream Dependency Bugs that affect this project, but need to be fixed in an upsteam library. label Sep 23, 2024
@jaydrogers jaydrogers moved this to Backlog in serversideup/php v3.4 Sep 23, 2024
@jaydrogers jaydrogers added the ✋ Status: Blocked This item requires something else to be completed first. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥶 Bug: Upstream Dependency Bugs that affect this project, but need to be fixed in an upsteam library. ⚡️ Enhancement Items that are new features requested to be added. ✋ Status: Blocked This item requires something else to be completed first.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant