Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit: Private IP address ranges are missing in the reverse proxy configuration, although they are specified in Nginx. #449

Open
jaydrogers opened this issue Oct 2, 2024 · 1 comment
Assignees
Labels
🧐 Bug: Needs Confirmation Something isn't working, but needs to be confirmed by a team member. 🙏 Help Wanted Issues that specifically could use some help from the community

Comments

@jaydrogers
Copy link
Member

Steps To Reproduce

TBD

Outcome

What did you expect?

  • TBD

What happened instead?

  • TBD

Affected Docker Images

Unit images only

Anything else?

Originally reported by @TheAndrey in #412:

Private IP address ranges are missing in the reverse proxy configuration, although they are specified in Nginx. I want to use Unit as an application server located behind the upstream Nginx on the host.

@jaydrogers jaydrogers added the 🧐 Bug: Needs Confirmation Something isn't working, but needs to be confirmed by a team member. label Oct 2, 2024
@jaydrogers jaydrogers self-assigned this Oct 2, 2024
@jaydrogers
Copy link
Member Author

I might circle back to this one with #450

To address this comment:

Private IP address ranges are missing in the reverse proxy configuration, although they are specified in Nginx. I want to use Unit as an application server located behind the upstream Nginx on the host.

Those CloudFlare IPs are only for the CF-Connecting-IP header.

We might have to create a separate specific section for 10.x.x.x, 192.168.x.x, etc using the X-Forwarded-For header, kind of like what @TheAndrey did in #450 :

  "listeners": {
    "*:8080": {
      "pass": "routes",
      "forwarded": {
        "client_ip": "X-Forwarded-For",
        "protocol": "X-Forwarded-Proto",
        "recursive": false,
        "source": [
          "172.16.0.0/12"
        ]
      }
    }
  },

@jaydrogers jaydrogers added the 🙏 Help Wanted Issues that specifically could use some help from the community label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧐 Bug: Needs Confirmation Something isn't working, but needs to be confirmed by a team member. 🙏 Help Wanted Issues that specifically could use some help from the community
Projects
None yet
Development

No branches or pull requests

1 participant