Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment succeeds when migration fails #477

Open
aagjalpankaj opened this issue Oct 19, 2024 · 0 comments · May be fixed by #478
Open

Deployment succeeds when migration fails #477

aagjalpankaj opened this issue Oct 19, 2024 · 0 comments · May be fixed by #478
Assignees
Labels
🧐 Bug: Needs Confirmation Something isn't working, but needs to be confirmed by a team member.

Comments

@aagjalpankaj
Copy link

Steps To Reproduce

  1. Set AUTORUN_ENABLED="true".
  2. Write a Laravel migration that can fail.
  3. Deploy the application. The migration will fail, but the deployment will succeed.

In such case, code changes will be deployed, but schema changes will not, which may break the application state.

Outcome

What did you expect?

Deployment should be rollbacked or should not succeed when migration fails

What happened instead?

Code changes deployed / Deployment succeeded

Affected Docker Images

I guess most of the images if people are using it for Laravel application with AUTORUN_ENABLED="true" option.

Anything else?

No response

@aagjalpankaj aagjalpankaj added the 🧐 Bug: Needs Confirmation Something isn't working, but needs to be confirmed by a team member. label Oct 19, 2024
@aagjalpankaj aagjalpankaj linked a pull request Oct 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧐 Bug: Needs Confirmation Something isn't working, but needs to be confirmed by a team member.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants