Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching of image files to build process #8

Closed
jaydrogers opened this issue Mar 9, 2021 · 6 comments
Closed

Add caching of image files to build process #8

jaydrogers opened this issue Mar 9, 2021 · 6 comments
Assignees
Labels
⚡️ Enhancement Items that are new features requested to be added.

Comments

@jaydrogers
Copy link
Member

jaydrogers commented Mar 9, 2021

Background

  • @szepeviktor was gracious and contributed caching
  • I temporarily commented this out in the actions file to solidify the build before

Caching will be helpful because:

  1. Saves time in CI
  2. We are good internet citizens by not draining @oerdnj's bandwidth resources

Scenarios to consider

✅ When we want a build

  • There is an update to the base_image (ubuntu:20.04)
  • There is an update in @oerdnj's repository

🛑 DO NOT build when

  • There are no updates for @oerdnj's repo

(notice we still need to build even if there are not updates for the base_image)

Possible solutions

  1. Check hash of @oerdnj's repo (http://ppa.launchpad.net/ondrej/php/ubuntu/dists/focal/Release)
  2. Something like docker run ... /bin/bash -c "dpkg -l|shasum"

Related comment: 26723e7#r48044607

Next steps

@jaydrogers jaydrogers self-assigned this Mar 9, 2021
@jaydrogers jaydrogers added the ✋ Status: Blocked This item requires something else to be completed first. label Mar 9, 2021
@szepeviktor
Copy link
Contributor

szepeviktor commented Mar 9, 2021

Cache (the hash of) this file: http://ppa.launchpad.net/ondrej/php/ubuntu/dists/focal/Release

Done 🍏

@szepeviktor
Copy link
Contributor

Please send the usual €1 000 000

@szepeviktor
Copy link
Contributor

szepeviktor commented Mar 9, 2021

Actually building the image and checking it for changes would be the ultimate solution.
But timestamps make it impossible.

But you may experiment with docker run ... /bin/bash -c "dpkg -l|shasum"

@jaydrogers
Copy link
Member Author

Adding a note, I wonder if we use "Build X" (BuildKit) as provided in this demo? https://github.com/docker/build-push-action

@szepeviktor
Copy link
Contributor

szepeviktor commented Mar 9, 2021

I wonder if we

To answer that you need someone who lives in the Docker ecosystem.

@jaydrogers jaydrogers changed the title Do we need to change the "build image" logic? Add caching of image files to build process Mar 9, 2021
@jaydrogers
Copy link
Member Author

Updated the notes above. Temporarily commented out the caching for now and will loop back to this later.

Focusing on the structure for now.

@jaydrogers jaydrogers added ⚡️ Enhancement Items that are new features requested to be added. and removed ✋ Status: Blocked This item requires something else to be completed first. labels May 28, 2021
@serversideup serversideup locked and limited conversation to collaborators Sep 22, 2022
@jaydrogers jaydrogers converted this issue into discussion #73 Sep 22, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
⚡️ Enhancement Items that are new features requested to be added.
Projects
None yet
Development

No branches or pull requests

2 participants