-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in log about missing vault when opening swagger #175
Comments
It is a soft dependency. Let me look into this right now |
Ahh it's a weird interaction between the OpenAPI annotations and Vault. Still digging |
OK this is because I changed the But changing it to provided means that any time the I think there's a solution to this, but it might take some work. Still looking |
Ah yeah. It's due to the the OpenAPI code doing reflection on PluginEntryPoint which declares a private static field of type |
Looks like 3edc3f9 fixed the issue. Introduced a new wrapper around the economy instance and made it a singleton. Now only economy related functionality causes the I tested it with and without Vault and an eco plugin and swagger loads/works fine. In addition the economy routes also work fine. Seems good to me. I'll release this as a new version shortly. |
First off:
I got two exceptions while trying out the swagger on a custom port on servertap. First:
Can't read from file http://myserverip:9998/swagger-docs"
and exceptions in the console. I don't have the vault plugin, since I thought it is a soft-dependency:
The text was updated successfully, but these errors were encountered: