Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing retain in CALayer::new #643

Closed
madsmtm opened this issue Nov 15, 2023 · 1 comment
Closed

Missing retain in CALayer::new #643

madsmtm opened this issue Nov 15, 2023 · 1 comment

Comments

@madsmtm
Copy link
Contributor

madsmtm commented Nov 15, 2023

+[CALayer layer] returns an autoreleased instance, but CALayer::new fails to retain said instance.

This leads to a double-free in CALayer's Drop implementation.
@madsmtm madsmtm mentioned this issue Nov 15, 2023
Closed
@nicoburns nicoburns mentioned this issue May 1, 2024
Merged
@wusyong
Copy link
Member

wusyong commented Aug 10, 2024

Fixed in #546

@wusyong wusyong closed this as completed Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wusyong @madsmtm