You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently OsIpcOneShotServer::new can panic in (see code):
let temp_dir = tempfile::Builder::new().tempdir().unwrap();
It would be good to raise the error instead. This would require modifying UnixError to have a variant Io(io::Error). This makes the UnixError struct larger and non copyable, but UnixError is converted to io::Error later on, this might be okay.
If you agree with this change, I'd send a PR.
The text was updated successfully, but these errors were encountered:
Currently
OsIpcOneShotServer::new
can panic in (see code):It would be good to raise the error instead. This would require modifying
UnixError
to have a variantIo(io::Error)
. This makes theUnixError
struct larger and non copyable, butUnixError
is converted toio::Error
later on, this might be okay.If you agree with this change, I'd send a PR.
The text was updated successfully, but these errors were encountered: