Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare shader validation options against gecko's choices #9

Open
jdm opened this issue Jun 8, 2018 · 1 comment
Open

Compare shader validation options against gecko's choices #9

jdm opened this issue Jun 8, 2018 · 1 comment

Comments

@jdm
Copy link
Member

jdm commented Jun 8, 2018

https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/dom/canvas/WebGLShaderValidator.cpp#31

There are some differences that we probably want to copy.

@asajeffrey
Copy link
Member

This is causing some macOS failures, e.g. /_webgl/conformance/glsl/misc/uninitialized-local-global-variables.html caused by not setting the `SH_INITIALIZE_UNINITIALIZED_LOCALS flag.

These failures don't show up in CI because there we're testing with --headless, which uses OSMesa.

Chat on #servo at https://chat.mozilla.org/#/room/#servo:mozilla.org/$Q9Tpvp1DwAuva_GPOGLlnDb_aZLauvvzXzvzMC46nQY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants