Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec inconsistency wrt forward slash after host if there's no path ? #531

Closed
o0Ignition0o opened this issue Jul 27, 2019 · 2 comments
Closed

Comments

@o0Ignition0o
Copy link
Contributor

As mentioned in my WIP pull request ( #523 ) I'm a bit confused wrt the forward slash uri parsing when there's no path :

a port setter test
seems to be inconsistent with a protocol setter test
There doesn't seem to be any consistency in WPT wrt the "/" when there is no path.
The specification seems to dismiss '/' at the end if there is no path:
" Otherwise, then for each string in url’s path, append U+002F (/) followed by the string to output."

Does anyone have any pointers on how I'm supposed to handle it ?

@SimonSapin
Copy link
Member

It’s possible that the spec has changed but the code has not code up yet. See #163 and #290.

@nox I think you mentioned something about empty paths? (Without even the initial slash)

@o0Ignition0o
Copy link
Contributor Author

Ok I may want to actually rollback my changes, and apply each patch separately, to make sure I don't get lost in the proces, thank for your reply :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants