You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
One of the webvr issues in Servo is that we freeze the eye parameters for a VRDisplay when the object is created, so if they change then the changes don't get seen by JS. servo/servo#22758
The obvious fix for this is to get the eye parameters from rust-webvr, but unfortunately the API for that is to get the VRDisplayData
Since the name is a String, it has to be freshly allocated each time the display data is accessed, which is wasteful.
Possible fixes: separate out the eye parameters from the display data, or make the display_name a &'static str or Cow<'static, str> rather than a String.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
One of the webvr issues in Servo is that we freeze the eye parameters for a
VRDisplay
when the object is created, so if they change then the changes don't get seen by JS. servo/servo#22758The obvious fix for this is to get the eye parameters from
rust-webvr
, but unfortunately the API for that is to get theVRDisplayData
rust-webvr/rust-webvr-api/src/vr_display.rs
Lines 12 to 13 in 4e30999
and the display data includes the
display_name
as aString
rust-webvr/rust-webvr-api/src/vr_display_data.rs
Lines 7 to 15 in 4e30999
Since the name is a
String
, it has to be freshly allocated each time the display data is accessed, which is wasteful.Possible fixes: separate out the eye parameters from the display data, or make the
display_name
a&'static str
orCow<'static, str>
rather than aString
.The text was updated successfully, but these errors were encountered: