Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

all PR labels are removed when merging #18

Closed
jdm opened this issue Oct 16, 2018 · 3 comments
Closed

all PR labels are removed when merging #18

jdm opened this issue Oct 16, 2018 · 3 comments

Comments

@jdm
Copy link
Member

jdm commented Oct 16, 2018

web-platform-tests/wpt#13511

@CYBAI
Copy link
Member

CYBAI commented Oct 23, 2018

also web-platform-tests/wpt#13681

@jdm
Copy link
Member Author

jdm commented Oct 23, 2018

Yes, this happens on every PR.

@CYBAI
Copy link
Member

CYBAI commented Jan 14, 2019

Maybe the third parameter should be { json: ['servo-export'] } *. (the array should be labels excluding 'do not merge yet'.)

https://github.com/servo-automation/upstream-wpt-sync-webhook/blob/c4f55fd020006d9ddcd5eadd9ed01a907974a83c/upstream_wpt_webhook/sync.py#L219-L220

Or, we can just remove a label with another endpoint which has the label name in the end of endpoint **?

*: https://developer.github.com/v3/issues/labels/#replace-all-labels-for-an-issue
**: https://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants