Just waiting on UI designs to attach to this issue before this can be picked up

Does this looks good enough?

I used native <select>, removed default arrow by setting background image to none, added my own arrow built with 0px border hack which has var(--input-border-color) as color. Added transitions to ensure colors are animated during theme change.

From the technical side, I wanted to use window.get/setSettingValue but it wasn't available on startup in main_node.ts, so I used userConfig instead with ipc events to sync between frontend and backend. It stores current language code in config and falls back the same way app falls back (process.env.LANGUAGE || app.getLocale() || 'en'). Languages are stored as part before _ character i.e. directory names in /_locales. Additionally, I'm using app.relaunch(); and app.exit(); to restart electron after changing language.

Languages in <select> are hardcoded and static, which means you have to edit this list each time new language is added or removed, because you need to write a language name anytime it's added anyway and I didn't want to spend time passing directory names into frontend, but I can patch this quickly if needed.

I can't create pull requests though, because I already forked this repository some time ago for https://github.com/VityaSchel/session-nodejs-bot and now it won't let me fork it second time 😅 I already submitted ticket to GitHub support, hopefully they'll be able to detach my bot framework into standalone repository tomorrow and then I'll create PR for review.

[Feature request] Option to change the UI's language. #699

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions