Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[drive-by CI improvement suggestion] Implement a unified gate check for branch protection #140

Open
webknjaz opened this issue May 30, 2024 · 3 comments

Comments

@webknjaz
Copy link
Contributor

I have a thing (https://github.com/marketplace/actions/alls-green#why — a shameless plug; you might've seen it integrated in CPython, pip, cryptography, etc.) that allows consolidating results of CI matrixes into a single gate.

The reason I'm bringing this up is that I noticed that only a portion of jobs are marked as required in PRs so it is likely that updating branch protection after updating the CI job definitions slipped off the radar.

This could be a good first issue for an external contributor, requiring just a little GHA experience.

@davisagli
Copy link
Collaborator

Thanks @webknjaz. Updating the branch protection rules requires admin permissions on the repository, so I think @sethmlarson has to do it.

@webknjaz
Copy link
Contributor Author

The workflow/job definition can be implemented separately. But the final bit would require an admin, yes.

@davisagli
Copy link
Collaborator

@webknjaz Ah, I misunderstood -- you're not merely proposing adding the jobs that are currently not required, but adding your tool to help make sure this doesn't need as much maintenance in the future. That sounds interesting to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants