Skip to content

Commit

Permalink
fix: add ember-fetch via a default blueprint instead
Browse files Browse the repository at this point in the history
  • Loading branch information
knownasilya committed Jan 9, 2019
1 parent 9ab9941 commit 78d97d5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
8 changes: 8 additions & 0 deletions blueprints/ember-cli-new-version/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
module.exports = {
normalizeEntityName() {}, // no-op since we're just adding dependencies

afterInstall() {
// Add addons to package.json and run defaultBlueprint
return this.addAddonToProject('ember-fetch');
}
};
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
"loader.js": "^4.7.0",
"mirage": "0.0.7",
"qunit-dom": "^0.8.0",
"standard-version": "^4.4.0"
"standard-version": "^4.4.0",
"ember-fetch": "^6.4.0"

This comment has been minimized.

Copy link
@jrjohnson

jrjohnson Jan 24, 2019

Contributor

@knownasilya why not provide fetch since it is required by this addon?

Also, I think this was a breaking change in removing this dependency updates will no longer function without changes to the app.

This comment has been minimized.

Copy link
@knownasilya

knownasilya Jan 24, 2019

Author Collaborator

Mainly because of ember-cli/ember-fetch#200 (comment)
I agree this should have probably been a major release. I missed that boat a few versions back, and since I broke the release I did subsequent releases as patches.

This comment has been minimized.

Copy link
@jrjohnson

jrjohnson Jan 24, 2019

Contributor

Well the other change didn't actually break our app - so I guess I didn't notice 😁

Thanks for the link, that's the info I couldn't find.

This comment has been minimized.

Copy link
@knownasilya

knownasilya Jan 24, 2019

Author Collaborator

Yeah at first it wasn't in dependencies and that was a mistake because it assumed the host app had fetch installed. Then it was moved to deps, and that cased the issue. You must have skipped that intermediate step or maybe it was a none issue if your app already had fetch.. 🤷‍♂️

},
"keywords": [
"ember-addon",
Expand All @@ -64,8 +65,7 @@
"broccoli-file-creator": "^2.1.1",
"ember-cli-babel": "^7.1.2",
"ember-cli-htmlbars": "^3.0.1",
"ember-concurrency": "^0.8.26",
"ember-fetch": "^6.4.0"
"ember-concurrency": "^0.8.26"
},
"ember-addon": {
"configPath": "tests/dummy/config"
Expand Down

0 comments on commit 78d97d5

Please sign in to comment.