Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling in dev #117

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Allow disabling in dev #117

merged 6 commits into from
Mar 30, 2022

Conversation

colenso
Copy link
Contributor

@colenso colenso commented Mar 28, 2022

Possible solution for #116

knownasilya
knownasilya requested changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small changes

addon/services/new-version.js Show resolved Hide resolved
addon/services/new-version.js Show resolved Hide resolved
@knownasilya knownasilya merged commit 6eb5a64 into sethwebster:master Mar 30, 2022
@knownasilya knownasilya mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knownasilya knownasilya knownasilya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colenso @knownasilya