Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-concurrency. #62

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Update ember-concurrency. #62

merged 2 commits into from
Sep 30, 2019

Conversation

colenso
Copy link
Contributor

@colenso colenso commented Sep 30, 2019

I've updated ember-concurrency to resolve service-injection related errors which I got after switching to ember 3.13 Here's the PR which fixed the problem machty/ember-concurrency#318

@knownasilya
Copy link
Collaborator

knownasilya commented Sep 30, 2019

Not sure if we want to just bump that without doing a major release since user's currently using this in < 3.13 and using EC in their apps would need to update their version since that would add two different EC versions to their apps without them knowing it. We could keep the ||s and just add 1.1.0 to that list for now, and in a major release clean out that list.

Copy link
Collaborator

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See my comment from earlier on how we should proceed.

@colenso
Copy link
Contributor Author

colenso commented Sep 30, 2019

Not sure if we want to just bump that without doing a major release since user's currently using this in < 3.13 and using EC in their apps would need to update their version since that would add two different EC versions to their apps without them knowing it. We could keep the ||s and just add 1.1.0 to that list for now, and in a major release clean out that list.

Done.

@knownasilya knownasilya merged commit c22a6f5 into sethwebster:master Sep 30, 2019
@knownasilya
Copy link
Collaborator

Released as v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants