Fix tests & Upgrade ember concurrency to 2.0 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there. Any progress on this PR? We are in the process of upgrading to e-concurrency v2 and this package seem one to be blocking that at the moment... edit: for what it's worth. upgrading e-concurrency was successful after upgrading ember-bootstrap... |
|
We don't use yarn in this addon, could you remove that and update the npm lock file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to fix the tests before upgrading, however the test
it yields the current and last version to the blockhas been failing randomly. The only workaround I could figure out, in the time I currently have available, was to increase the timeout. The issue seems thatwaitUntilfinishes before thefetchrequest is finished and therefor the new version is not always updated beforeassertis called. Probably it would be better to assert afteronNewVersionhas been called, but I am not sure about the purpose of this test.Btw: Upgrading ember fetch fixes most of the current issues with the tests