Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove set-output from workflows #105

Closed
10 tasks
tomwillis608 opened this issue Jan 23, 2023 · 0 comments · Fixed by #106
Closed
10 tasks

chore: remove set-output from workflows #105

tomwillis608 opened this issue Jan 23, 2023 · 0 comments · Fixed by #106
Assignees
@tomwillis608

Comments

@tomwillis608
Copy link
Member

Describe the User Story

Comply with GHA changes that obsolete set-output
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Acceptance Criteria

set-output is no longer used in the GHA workflows in this repo

Definition of Done

  • Acceptance criteria met
  • Usability tests passed - this user story should be easy to use by real users
  • Code refactored for clarity - code must be clean, self-documenting code
  • Dependency Rule followed - higher-level code should not depend directly on lower-level code
  • Source code merged
  • Unit test coverage of our code > 90%
  • Security reviewed and reported - includes vulnerability and compliance scanning
  • Code quality checks passed
  • Build process updated if needed
  • API documentation updated if needed

Additional Information

No response

Related Feature Request

No response
@tomwillis608 tomwillis608 changed the title chore: chore: remove set-output from workflows Jan 23, 2023
@tomwillis608 tomwillis608 self-assigned this Jan 23, 2023
@tomwillis608 tomwillis608 linked a pull request Jan 23, 2023 that will close this issue
Switch to new environment output file #106
Merged
13 tasks
@tomwillis608 tomwillis608 mentioned this issue Jan 23, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomwillis608 tomwillis608

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to new environment output file sett-and-hive/sarif-to-comment-action
1 participant
@tomwillis608