Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Unexpected input(s) 'pr_number' ? #93

Closed
abcfy2 opened this issue Jan 11, 2023 · 3 comments · Fixed by #104
Closed

bug: Unexpected input(s) 'pr_number' ? #93

abcfy2 opened this issue Jan 11, 2023 · 3 comments · Fixed by #104
Assignees

Comments

@abcfy2
Copy link

abcfy2 commented Jan 11, 2023

Version

2.0.0

Current Behavior

image

Expected Behavior

Should no warnings.

Steps to Reproduce

Just like README.md

Additional Information

No response

@tomwillis608 tomwillis608 self-assigned this Jan 23, 2023
@tomwillis608
Copy link
Member

@abcfy2 it appears that the README is erroneous in two places where it refers to the pr-number parameter for the action is incorrectly named pr_number in two of the YAML examples.

The correct parameter name, as in the first example, is pr-number. The README will be updated to show the corrected value:

- name: Post SARIF findings in the pull request
  if: github.event_name == 'pull_request'
  uses: sett-and-hive/sarif-to-comment-action@v1
  with:
    token: ${{ secrets.GITHUB_TOKEN }}
    repository: ${{ github.repository }}
    branch: ${{ github.head_ref }}
    pr-number: ${{ github.event.number }}
    sarif-file: scan/results/xss.sarif
    title: My security issue
    dry-run: false

@tomwillis608 tomwillis608 mentioned this issue Jan 23, 2023
13 tasks
@tomwillis608
Copy link
Member

tomwillis608 commented Jan 23, 2023

Reproduced this issue by changing pr-number to pr_number in the action
image

https://github.com/sett-and-hive/sarif-to-comment-action/actions/runs/3982473961

@tomwillis608 tomwillis608 linked a pull request Jan 23, 2023 that will close this issue
13 tasks
@tomwillis608 tomwillis608 reopened this Jan 23, 2023
@tomwillis608
Copy link
Member

Resolved in new version v2.0.1 now on the Marketplace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants