Skip to content

[BUG] Exception thrown on valid input #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
estebanthebad opened this issue May 3, 2022 · 2 comments
Closed

[BUG] Exception thrown on valid input #3

estebanthebad opened this issue May 3, 2022 · 2 comments

Comments

@estebanthebad
Copy link

https://github.com/sms77io/php-client/blob/ec0339d72bcdfa930b80ab1c8cd2e2838b944d46/src/Validator/SmsValidator.php#L115

This code block throws an exception if the string consists of valid characters but solely of characters listed in SmsConstants::FROM_ALLOWED_CHARS. Because after the replace command the string will be empty and ctype_alnum() will return FALSE.

@matthiez
Copy link
Contributor

matthiez commented May 6, 2022

thanks for reporting @estebanthebad will fix asap in the next release but im quite busy with other stuff atm - feel free to open a pull request on your own though :)

@cl77
Copy link
Member

cl77 commented Apr 26, 2024

Fixed with latest release.

@cl77 cl77 closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants