-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransactionBuilder::start
Future dropped before completion
#1120
Comments
Good find. We should probably implement |
Makes sense. Anything else you need from my end? Is this something you'd knock out quickly or would you rather have a PR? |
Either way! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
batch_execute
submits the creation of the transaction (https://github.com/sfackler/rust-postgres/blob/master/tokio-postgres/src/transaction_builder.rs#L109), but theTransaction
object itself may never be constructed in case the future is dropped.f6189a9 fixed it for
Client::transaction
.The text was updated successfully, but these errors were encountered: