Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Support Timout for Connect Methods #15

Open
ghost opened this issue Apr 12, 2020 · 1 comment
Open

Feature Request: Support Timout for Connect Methods #15

ghost opened this issue Apr 12, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 12, 2020

Hi, thanks for this crate.

I recently implemented support for SOCKS in ureq using this crate, using std::thread and condvar for connection timout, which is suboptimal.

I had a look at the implementation of Socks5Stream::connect which uses BufReader so it's not obvious to me how to implement this.

Please could I have some advice how to implement this so I could submit a PR?
@RCasatta
Copy link

I am interested too in supporting timeout in this lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RCasatta