You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This could probably be broken up into multiple issues. The code that powers the front end is really monolithic and is primarily sourced from a ~900 line file.
Proposal:
For now? Tests. The code is rather verbose and could be refactored quite a bit. After tests are done, it could be broken up into multiple files and then later loaded using a module loader like Webpack, Browserify, RequireJS, etc.
I dunno'. Thoughts? Objections?
The text was updated successfully, but these errors were encountered:
Rails asset pipeline allows for some modularization -- we could also take more advantage of UJS via remote: true forms and what-have-you to avoid the need to have JS binding to the forms and doing the AJAX submit.
You are correct that there don't appear to be any tests at that level. If we end up replacing the Javascript with Rails UJS stuff, it may make more sense to do capybara tests than actual JS tests since much of the code would basically disappear. We could then have JS tests for the remaining components.
This could probably be broken up into multiple issues. The code that powers the front end is really monolithic and is primarily sourced from a ~900 line file.
Proposal:
For now? Tests. The code is rather verbose and could be refactored quite a bit. After tests are done, it could be broken up into multiple files and then later loaded using a module loader like Webpack, Browserify, RequireJS, etc.
I dunno'. Thoughts? Objections?
The text was updated successfully, but these errors were encountered: