Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMartins\Exceptions\Handlers\Handler can't handle non-exception throwables. #11

Open
guice opened this issue Aug 24, 2020 · 0 comments
Open

SMartins\Exceptions\Handlers\Handler can't handle non-exception throwables. #11

guice opened this issue Aug 24, 2020 · 0 comments

Comments

@guice
Copy link

guice commented Aug 24, 2020

Getting type error mismatching when a non-Exception throwable is thrown:

TypeError : Argument 1 passed to SMartins\Exceptions\Handlers\AbstractHandler::__construct() must be an instance of Exception, instance of TypeError given, called in [....]/sfelix-martins/json-exception-handler/src/JsonHandler.php on line 20

__construct() needs to be updated to accept \Throwable types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guice