-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refile support #2385
Add refile support #2385
Conversation
@@ -47,6 +47,9 @@ group :test do | |||
gem 'paperclip', ['>= 3.4', '!= 4.3.0'] | |||
gem 'poltergeist', '~> 1.5' | |||
gem 'rack-cache', require: 'rack/cache' | |||
gem 'refile', '>= 0.5.5', require: 'refile/rails' | |||
gem 'refile-mini_magick', '>= 0.1.0' | |||
gem 'refile-mongoid', '>= 0.0.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refile-mongoid
should go into :mongoid
group, since it is only required for mongoid builds.
CI build is failing, can you investigate? |
I'll fix it.
I forgot to check required Ruby version of the refile gem. It needs >= 2.1.0. This is one reason of build failure. So is it difficult to merge this request? Build failures also occurred when satisfy refile required Ruby version. I can investigate reasons of this failures. |
Then you can conditionally install(and test) refile gem for Ruby >= 2.1.0. To merge in, passing all builds is mandatory. |
I add conditional statements of Ruby version for build failures fix. The build failures when satisfy refile required Ruby version, cause sass-rails version. I cannot investigate detailed reason. However I found a workaround. If I add Then all tests have been passed now. |
Merged in, thanks 🙆♀️ |
Conditionally executed code in #2385 decreases coverage so much 😵
Add support for a modern file upload library. https://github.com/refile/refile