Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Default filter operator for fields #3318

Merged
merged 7 commits into from
Feb 28, 2021

Conversation

mitchkettzend
Copy link
Contributor

@mitchkettzend mitchkettzend commented Nov 11, 2020

Issue
When a filter is initially added on the filter criteria on a list view, the default operator is nil or empty which makes it necessary for the user to select an operator each time they add a filter. This can be a bit cumbersome especially if users search a field by a particular operator the majority of the time.

Proposed change
A field option to set a default filter operator for a field which populates the filter operator select box when initially added to the filter criteria. If one is not specified then it will default to the original behavior of setting the operator to nil or empty.

@mitchkettzend mitchkettzend marked this pull request as ready for review November 11, 2020 20:30
@mshibuya mshibuya merged commit 3d8cb28 into railsadminteam:master Feb 28, 2021
@mshibuya
Copy link
Member

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants