Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple identity map from object instantiation #286

Merged
merged 5 commits into from
Jul 11, 2012
Merged

Conversation

stve
Copy link
Collaborator

@stve stve commented Jul 11, 2012

Modifications to Twitter::Base and Twitter::Identity to decouple the identity map from object instantiation which should fix #285

@sferik
Copy link
Owner

sferik commented Jul 11, 2012

I'm happy to pull this now. The code seems like a net improvement and is worthy of being merged into master.

However, it leaves the issue of "child" objects (discussed here) unresolved. I'd like to figure this out before releasing version 3.2.0, but it doesn't necessarily need to be part of this pull request.

Do you want me to pull now or wait for that issue to be resolved?

@stve
Copy link
Collaborator Author

stve commented Jul 11, 2012

The implementation we've been discussing deviates quite a bit from the original intent of this pull request. It probably makes sense to merge in before it snowballs into something much larger. I'll make a new branch for the new changes.

sferik added a commit that referenced this pull request Jul 11, 2012
Decouple identity map from object instantiation
@sferik sferik merged commit 4c4ffde into master Jul 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a way to disable the identity map
2 participants