Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note from CRAN that tests are failing with R 3.2.5 on Windows #76

Closed
sfirke opened this issue Oct 23, 2016 · 3 comments
Closed

Note from CRAN that tests are failing with R 3.2.5 on Windows #76

sfirke opened this issue Oct 23, 2016 · 3 comments

Comments

@sfirke
Copy link
Owner

sfirke commented Oct 23, 2016

Note from Uwe Ligges:

Dear maintainer,

please see

https://cran.r-project.org/web/checks/check_results_janitor.html

and find that your package faild under R-oldrelease (R-3.2.5) with the packages available there. Please fix or declare proper version dependencies and resubmit.

Relevant part of the log:

checking tests ... ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
  `%>%`(...) not equal to "bad name".
  1/1 mismatches
  x[1]: "bad.name"
  y[1]: "bad name"


  testthat results ================================================================
  OK: 189 SKIPPED: 0 FAILED: 2
  1. Failure: bad input variable name is preserved (@test-crosstab.R#108) 
  2. Failure: bad input variable name is preserved (@test-tabyl.R#100) 

  Error: testthat unit tests failed
  Execution halted

While I am curious to know why this code does not work under R 3.2.5 for Windows, from April 2016, I don't think I should spend time looking into this. Instead, I'll specify a dependency on R >= 3.3.0, which I verified works. That was released May 2016, so hopefully there aren't many people who haven't updated since then who will be inconvenienced by this.

@sfirke sfirke closed this as completed in 1796d8a Oct 23, 2016
@sfirke
Copy link
Owner Author

sfirke commented Oct 23, 2016

My curiosity got the better of me and I installed R 3.2.5 for Windows (thanks CRAN for having a .exe and RStudio for making it easy to toggle back and forth). Turns out as.data.frame(..., check.names = FALSE) was not working but data.frame(..., check.names = FALSE) did. So not adding that dependency above after all.

Though I did run into trouble not having dplyr 0.5.0 in the old R environment, so I added that specification to Imports in the DESCRIPTION file. Not 100% sure how that will play out so please do open an issue if it causes problems or confusion.

@sfirke sfirke reopened this Oct 23, 2016
@sfirke
Copy link
Owner Author

sfirke commented Oct 23, 2016

Opening until I actually resubmit to CRAN

@sfirke
Copy link
Owner Author

sfirke commented Oct 31, 2016

fixed in version 0.2.1 now on CRAN!

@sfirke sfirke closed this as completed Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant